Postgres Pro
Downloads
Home   >   mailing lists

Remove extra Logging_collector check before calling SysLogger_Start() - Mailing list pgsql-hackers

From Bharath Rupireddy
Subject Remove extra Logging_collector check before calling SysLogger_Start()
Date
Msg-id CALj2ACV9J=bwTrJJPc+nr6SBijsnoCCMB2Lf7xE6tJ7gShnzew@mail.gmail.com
Whole thread Raw
Responses Re: Remove extra Logging_collector check before calling SysLogger_Start()  (Daniel Gustafsson <daniel@yesql.se>)
List pgsql-hackers
Tree view 
Hi,

It seems like there's an extra Logging_collector check before calling
SysLogger_Start(). Note that the SysLogger_Start() has a check to
return 0 if Logging_collector is off. This change is consistent with
the other usage of SysLogger_Start().

                /* If we have lost the log collector, try to start a new one */
-               if (SysLoggerPID == 0 && Logging_collector)
+               if (SysLoggerPID == 0)
                        SysLoggerPID = SysLogger_Start();

Attaching a tiny patch to fix. Thoughts?

Regards,
Bharath Rupireddy.
Attachment

pgsql-hackers by date:

Previous
From: "tanghy.fnst@fujitsu.com"
Date:
Subject: RE: Alter all tables in schema owner fix
Next
From: Daniel Gustafsson
Date:
Subject: Re: Remove extra Logging_collector check before calling SysLogger_Start()