Re: REPACK (CONCURRENTLY) fails with wrong error for materialized views - Mailing list pgsql-hackers

From Bharath Rupireddy
Subject Re: REPACK (CONCURRENTLY) fails with wrong error for materialized views
Date
Msg-id CALj2ACUgYCWANVDuVFWs0Ef2dz1T_+5WV1Od50Mx-NGBDmR6Vg@mail.gmail.com
Whole thread
List pgsql-hackers
Hi,

On Sat, Aug 29, 2026 at 1:42 PM Kiran Kaki <itskkpg@gmail.com> wrote:
>
> Hi Bharath,
>
> I verified the change, and it works as intended. The new check is appropriately placed before replica identity
validation.The error is much clearer than the previous "has no identity index" message, and the documentation update
looksgood to me. 
>
> My only suggestion is to add an automated  test as it can help catch any future regressions in this behavior.

Thanks for reviewing and verifying the change. I think we can skip the
test for this one since the change is straightforward and unlikely to
regress.

--
Bharath Rupireddy
Amazon Web Services: https://aws.amazon.com



pgsql-hackers by date:

Previous
From: Melanie Plageman
Date:
Subject: Re: WAL_LOG CREATE DATABASE strategy broken for non-standard page layouts
Next
From: Vitaly Davydov
Date:
Subject: Re: Deadlock detector fails to activate on a hot standby replica