pg_waldump stucks with options --follow or -f and --stats or -z - Mailing list pgsql-hackers

From Bharath Rupireddy
Subject pg_waldump stucks with options --follow or -f and --stats or -z
Date
Msg-id CALj2ACUUx3PcK2z9h0_m7vehreZAUbcmOky9WSEpe8TofhV=PQ@mail.gmail.com
Whole thread Raw
Responses Re: pg_waldump stucks with options --follow or -f and --stats or -z
List pgsql-hackers
Hi,

pg_waldump options, --follow or -f(to keep polling once per second for
new WAL to appear) and --stats or -z don't work well together i.e. the
command stucks [1]. I think the pg_waldump should emit an error. Note
that the pg_basebakup does error out on incompatible options.

Here's a small patch for fixing above along with a note in the documentation.

Thoughts?

[1] The following commands stuck:
./pg_waldump -p data/ -s 0/7000060 -f -z
./pg_waldump -p data/ -s 0/7000060 -f --stats='record'
./pg_waldump -p data/ -s 0/7000060 -f --stats='rmgr'

[2]
ubuntu3:~/postgres/inst/bin$ ./pg_waldump -p data/ -s 0/7000060 -f -z
pg_waldump: error: --follow and --stats are incompatible options
Try "pg_waldump --help" for more information.
bharath@bharathubuntu3:~/postgres/inst/bin$

Regards,
Bharath Rupireddy.

Attachment

pgsql-hackers by date:

Previous
From: torikoshia
Date:
Subject: Re: RFC: Logging plan of the running query
Next
From: Bharath Rupireddy
Date:
Subject: Re: RFC: Logging plan of the running query