On Sun, 10 Aug 2025 at 21:37, Noah Misch <noah@leadboat.com> wrote:
>
> Thanks. Could you make src/test/regress create regression database objects so
> the code addition has coverage? Using pg_signal_backend and
> pg_read_all_settings as the default ACL role names should avoid that suite's
> limitations. (The suite must run under any role name and must drop any roles
> it creates, so it can't assume any particular non-system role name survives
> the suite.)
Here is my attempt at implementing necessary legwork. It's v3 because
I accidentally cleared the CC list in my previous attempt. Noah kindly
explained to me how additions to the regress test will cause pg_dump
logic to be tested as well.
TIL 002_pg_upgarde.pl runs a regression suite, so if we create any
database objects in it, it will end up being dumped and restored in
that test.
So, I checked that without changes in pg_dump_sort.c, 002_pg_upgarde
fails and with changes it does not.
PFA. I am not horribly sure about my additions to the
`src/test/regress/sql/privileges.sql` file, maybe appending SQL to the
end of the file is not the best option and there is a better place.
--
Best regards,
Kirill Reshke
