Re: citext_1.out, citext.out confusing comment - Mailing list pgsql-hackers

From Kirill Reshke
Subject Re: citext_1.out, citext.out confusing comment
Date
Msg-id CALdSSPj6i=5w8hEAgxMtKxVQiW5+rJX9bxkzAhY2pRgRz8bx8w@mail.gmail.com
Whole thread Raw
In response to citext_1.out, citext.out confusing comment  (jian he <jian.universality@gmail.com>)
Responses Re: citext_1.out, citext.out confusing comment
List pgsql-hackers


On Tue, 9 Dec 2025, 10:08 jian he, <jian.universality@gmail.com> wrote:
hi.

While working on CAST DEFAULT, I found out citext_1.out, citext.out comments are
confusing.

contrib/citext/expected/citext_1.out:
SELECT 'a'::citext >= 'B'::text AS t;  -- text wins.
 t
---
 f
(1 row)


contrib/citext/expected/citext.out:
SELECT 'a'::citext >= 'B'::text AS t;  -- text wins.
 t
---
 t
(1 row)

same input, return different result,  The comment "-- text wins."
seems confusing.
(this happens in other places within citext.out, citext_1.out).


Well, that's because there is single sql test file, so no variation here is possible. We can simply delete comment, or we can rephrase it to reflect, under which conditions text wins

pgsql-hackers by date:

Previous
From: Bertrand Drouvot
Date:
Subject: Re: Safer hash table initialization macro
Next
From: Yu Wang
Date:
Subject: Re: Add mode column to pg_stat_progress_vacuum