Re: Test instability when pg_dump orders by OID - Mailing list pgsql-hackers

From Kirill Reshke
Subject Re: Test instability when pg_dump orders by OID
Date
Msg-id CALdSSPghJyU+8_xGqP7a_Jn12b9OTNxSAnEBvYkescZ_CzmWwg@mail.gmail.com
Whole thread Raw
In response to Re: Test instability when pg_dump orders by OID  (Noah Misch <noah@leadboat.com>)
Responses Re: Test instability when pg_dump orders by OID
List pgsql-hackers
On Sun, 10 Aug 2025 at 21:37, Noah Misch <noah@leadboat.com> wrote:

> Thanks.  Given the current state of freeze for tomorrow's release wrap, the
> decision is less obvious than usual.  I'm seeing these options:
>
> 1. Remove the new assertion in v13-v18.
> 2. Push your proposed fix.
> 3. Change nothing.  (This would be the choice if one is maximally concerned
>    about deviating from the freeze and unconcerned about --enable-cassert
>    builds of releases.)
>
> I am inclined to make today's change be (1).  A fresh audit of catalog PRIMARY
> KEY and UNIQUE constraints didn't find any more missed cases, but (1) still
> feels like the right level of cautiousness.  If there are no objections in the
> next 3hr, I'll proceed with (1).
>

Hi! I can see we have option (1)  (28e7252 etc). Can we now move
forward with option (2) for HEAD?


-- 
Best regards,
Kirill Reshke



pgsql-hackers by date:

Previous
From: Yugo Nagata
Date:
Subject: Re: Allow to collect statistics on virtual generated columns
Next
From: Ajin Cherian
Date:
Subject: Re: Improve pg_sync_replication_slots() to wait for primary to advance