On Sat, 27 Dec 2025 at 05:50, Tatsuya Kawata
<kawatatatsuya0913@gmail.com> wrote:
>
> Hi Chao-san,
>
> Thank you very much for your review!
>
> > Firs the first case:
> > ```
> > +# check DELETE ... USING completion
> > +check_completion(
> > + "DELETE FROM tab1 USING my\t",
> > + qr/mytab/,
> > + "complete DELETE FROM tab USING with table name");
> > ```
> >
> > Maybe just say “with tab”, because the rest test cases’ messages all say “USING tab”.
> I fixed it as you mentioned.
> The updated v2 is attached.
>
> Regards,
> Tatsuya Kawata
HI! What makes you think we need additional tab completion tests at all?
If we consult src/bin/psql changes history [0], it can be easily seen
that not every change to tab-complete.in.c is made with a new test.
This is (my own understanding, I may be wrong) because we only need to
test tab-complete patterns that are functionally different, not mirror
all cases from tab-complete.in.c in the TAP test.
WDYT?
[0] https://github.com/postgres/postgres/commits/master/src/bin/psql
--
Best regards,
Kirill Reshke
