Request a Demo
Home   >   mailing lists

Re: [PATCH] intXshr, intXshl: return error on shift count out of range - Mailing list pgsql-hackers

From Pavel Borisov
Subject Re: [PATCH] intXshr, intXshl: return error on shift count out of range
Date
Msg-id CALT9ZEGJxDP6SCWzpKFiRCtD4oaENPsCrmP6SVYoaJEMQXRfMQ@mail.gmail.com
Whole thread
Responses Re: [PATCH] intXshr, intXshl: return error on shift count out of range
List pgsql-hackers
Tree view 
Hi, Egor!

On Wed, 30 Sept 2026 at 18:03, Egor Ivkov <e.ivkov@arenadata.io> wrote:
>
> Small fix for .out files to contain rightmost spaces.
>
> Regards,
> Egor Ivkov

Your patch looks good to me except the similar behavior of int2 and
int4 are never explained. In C11 and older int16  left arg bit shift
is not UB only if the result filts int32. There is no check for this
in the patch.

Regards,
Pavel Borisov
Supabase

pgsql-hackers by date:

Previous
From: Alexandre Felipe
Date:
Subject: Re: BUG #19686: Rolling back SET TABLESPACE
Next
From: Antonin Houska
Date:
Subject: Re: REPACK (CONCURRENTLY) might keep dropped-column data