Postgres Pro
Downloads
Home   >   mailing lists

checking return value from unlink in write_relcache_init_file - Mailing list pgsql-hackers

From Zhihong Yu
Subject checking return value from unlink in write_relcache_init_file
Date
Msg-id CALNJ-vT-oSAO7yDQ6bQuXbAtJ9=zTznLidoMJ3CBs2EYQUuu3g@mail.gmail.com
Whole thread Raw
Responses Re: checking return value from unlink in write_relcache_init_file  (Justin Pryzby <pryzby@telsasoft.com>)
Re: checking return value from unlink in write_relcache_init_file  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tree view
Hi,
I was looking at write_relcache_init_file() where an attempt is made to unlink the tempfilename.

However, the return value is not checked.
If the tempfilename is not removed (the file exists), I think we should log a warning and proceed.

Please comment on the proposed patch.

Thanks
Attachment

pgsql-hackers by date:

Previous
From: Isaac Morland
Date:
Subject: Re: DELETE CASCADE
Next
From: Justin Pryzby
Date:
Subject: Re: checking return value from unlink in write_relcache_init_file