Home > mailing lists

checking return value from unlink in write_relcache_init_file - Mailing list pgsql-hackers

From	Zhihong Yu
Subject	checking return value from unlink in write_relcache_init_file
Date	June 4, 2021 01:44:13
Msg-id	CALNJ-vT-oSAO7yDQ6bQuXbAtJ9=zTznLidoMJ3CBs2EYQUuu3g@mail.gmail.com Whole thread Raw
Responses	Re: checking return value from unlink in write_relcache_init_file Re: checking return value from unlink in write_relcache_init_file
List	pgsql-hackers

Hi,

I was looking at write_relcache_init_file() where an attempt is made to unlink the tempfilename.

However, the return value is not checked.

If the tempfilename is not removed (the file exists), I think we should log a warning and proceed.

Please comment on the proposed patch.

Thanks

From: Isaac Morland
Date: 04 June 2021, 01:29:29
Subject: Re: DELETE CASCADE

From: Justin Pryzby
Date: 04 June 2021, 01:54:14
Subject: Re: checking return value from unlink in write_relcache_init_file