Re: very long record lines in expanded psql output - Mailing list pgsql-hackers

From Zhihong Yu
Subject Re: very long record lines in expanded psql output
Date
Msg-id CALNJ-vScipjoeAbUnV+z3jb1ZXAHUjJLipoTd4_2zh5tRt61zA@mail.gmail.com
Whole thread Raw
In response to Re: very long record lines in expanded psql output  (Platon Pronko <platon7pronko@gmail.com>)
Responses Re: very long record lines in expanded psql output  (Platon Pronko <platon7pronko@gmail.com>)
List pgsql-hackers


On Sun, Oct 3, 2021 at 5:57 AM Platon Pronko <platon7pronko@gmail.com> wrote:
On 2021-09-24 14:42, Andrew Dunstan wrote:
>
> On 9/24/21 12:49 AM, Platon Pronko wrote:
>> On 2021-09-23 22:28, Andrew Dunstan wrote:
>>>
>>> 2. It would possibly be better to pass the relevant parts of the options
>>> to print_aligned_vertical_line() rather than the whole options
>>> structure. It feels odd to pass both that and opt_border.
>>
>> What do you think about doing it the other way around - passing only
>> whole
>> options structure? That way we will roll 4 parameters (opt_border,
>> printTextFormat,
>> and two xheader ones) into only one argument.
>> This increases code coupling a bit, but I'm not sure if that's
>> relevant here.
>>
>
> Sure, as long as it doesn't result in duplicated computation.

Hi!

Please find attached the updated patch - with fixed braces and
adjusted parameters to print_aligned_vertical_line().

Best regards,
Platon Pronko

Hi,

+               pg_log_error("\\pset: allowed xheader_width values are full (default), column, page, or an number specifying exact width.");

 an number specifying -> a number specifying

Cheers

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: 2021-09 Commitfest
Next
From: Jaime Casanova
Date:
Subject: Re: 2021-09 Commitfest