Postgres Pro
Downloads
Home   >   mailing lists

Re: TRUNCATE on foreign table - Mailing list pgsql-hackers

From Zhihong Yu
Subject Re: TRUNCATE on foreign table
Date
Msg-id CALNJ-vSDcJhqQ1Wq8dq+gdtesfuyc++eC7rNZFvKfB003q2Qhg@mail.gmail.com
Whole thread Raw
In response to TRUNCATE on foreign table  (Kazutaka Onishi <onishi@heterodb.com>)
Responses Re: TRUNCATE on foreign table
List pgsql-hackers
Tree view
Hi,
+               if (strcmp(defel->defname, "truncatable") == 0)
+                   server_truncatable = defGetBoolean(defel);

Looks like we can break out of the loop when the condition is met.

+           /* ExecForeignTruncate() is invoked for each server */

The method name in the comment is slightly different from the actual method name.

+           if (strcmp(defel->defname, "truncatable") == 0)
+               truncatable = defGetBoolean(defel);

We can break out of the loop when the condition is met.

Cheers

On Sat, Feb 6, 2021 at 5:11 AM Kazutaka Onishi <onishi@heterodb.com> wrote:
Hello, 

The attached patch is for supporting "TRUNCATE" on  foreign tables.

This patch includes:
* Adding "ExecForeignTruncate" function into FdwRoutine.
* Enabling "postgres_fdw" to use TRUNCATE.

This patch was proposed by Kaigai-san in March 2020, 
but it was returned because it can't be applied to the latest source codes.

Please refer to the discussion.

I have fixed the patch due to submit it to Commit Fest 2021-03.  

regards,

--
------------------
Kazutaka Onishi

pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: Fuzz testing COPY FROM parsing
Next
From: Zhihong Yu
Date:
Subject: Re: CLUSTER on partitioned index