Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Optimize json_lex_string by batching character copying - Mailing list pgsql-hackers

From Zhihong Yu
Subject Re: [PATCH] Optimize json_lex_string by batching character copying
Date
Msg-id CALNJ-vRZhA2d+k8XD7P5mLYEC_m9bdPL9gx8Ys+475=BiSa=gw@mail.gmail.com
Whole thread Raw
In response to [PATCH] Optimize json_lex_string by batching character copying  (Jelte Fennema <Jelte.Fennema@microsoft.com>)
Responses Re: [PATCH] Optimize json_lex_string by batching character copying
Re: [PATCH] Optimize json_lex_string by batching character copying
List pgsql-hackers
Tree view
Hi,
Looking at the patch,

+           if (copyable_characters_length)
+           {
+               /* flush copyable characters */
+               appendBinaryStringInfo(
+                                      lex->strval,
+                                      s - copyable_characters_length,
+                                      copyable_characters_length);
+
+           }
            break;

I wonder why copyable_characters_length is not reset after flushing.

Cheers

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: pg_auth_members.grantor is bunk
Next
From: Thomas Munro
Date:
Subject: Re: Future Postgres 15 and Clang 15