Postgres Pro
Downloads
Home   >   mailing lists

Re: doc: add missing "id" attributes to extension packaging page - Mailing list pgsql-hackers

From vignesh C
Subject Re: doc: add missing "id" attributes to extension packaging page
Date
Msg-id CALDaNm3oEpFzMk6kukkyoBZ+z9WsE1yCow6sGGu+bmx4WFqCDg@mail.gmail.com
Whole thread Raw
In response to Re: doc: add missing "id" attributes to extension packaging page  ("Karl O. Pinc" <kop@karlpinc.com>)
Responses Re: doc: add missing "id" attributes to extension packaging page
Re: doc: add missing "id" attributes to extension packaging page
List pgsql-hackers
Tree view 
On Wed, 4 Jan 2023 at 04:13, Karl O. Pinc <kop@karlpinc.com> wrote:
>
> On Tue, 3 Jan 2023 21:35:09 +0100
> Brar Piening <brar@gmx.de> wrote:
>
> > On 02.01.2023 at 21:53, Karl O. Pinc wrote:
> > > If the author will look over my version of the patch I believe it
> > > can be approved and sent on to the committers.
> >
> > LGTM.
>
> Approved for committer!

The patch does not apply on top of HEAD as in [1], please post a rebased patch:
=== Applying patches on top of PostgreSQL commit ID
cd9479af2af25d7fa9bfd24dd4dcf976b360f077 ===
=== applying patch ./add_html_ids_v2.patch
....
patching file doc/src/sgml/ref/pgbench.sgml
patching file doc/src/sgml/ref/psql-ref.sgml
Hunk #73 FAILED at 1824.
....
2 out of 208 hunks FAILED -- saving rejects to file
doc/src/sgml/ref/psql-ref.sgml.rej

[1] - http://cfbot.cputube.org/patch_41_4041.log

Regards,
Vignesh

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PATCH] random_normal function
Next
From: vignesh C
Date:
Subject: Re: doc: add missing "id" attributes to extension packaging page