On Wed, Sep 1, 2021 at 6:58 AM houzj.fnst@fujitsu.com
<houzj.fnst@fujitsu.com> wrote:
>
> Here are some other comments for v23-000x patches.
>
> 1)
>
> @@ -6225,6 +6342,9 @@ describePublications(const char *pattern)
> bool has_pubtruncate;
> bool has_pubviaroot;
>
> + PQExpBufferData title;
> + printTableContent cont;
> +
> if (pset.sversion < 100000)
> {
> ...
> PQExpBufferData title;
> printTableOpt myopt = pset.popt.topt;
> printTableContent cont;
>
> Should we delete the inner declaration of 'title' and 'cont' ?
Modified
> 2)
> - /* parameters used for ALTER PUBLICATION ... ADD/DROP TABLE */
> + /* parameters used for ALTER PUBLICATION ... ADD/DROP TABLE/SCHEMA */
>
> SCHEMA => ALL TABLES IN SCHEMA
Modified
> 3)
>
> + .description = "PUBLICATION SCHEMA",
> + .section = SECTION_POST_DATA,
> + .createStmt = query->data));
>
> Is it better to use something like 'PUBLICATION TABLES IN SCHEMA' to describe
> the schema level table publication ? Because there could be some other type
> publication such as 'ALL SEQUENCES IN SCHEMA' in the future, it will be better
> to make it clear that we only publish table in schema in this patch.
Modified
Thanks for the comments, the v24 patch attached at [1] handles the comments.
[1] - https://www.postgresql.org/message-id/CALDaNm27bs40Rxpy4oKfV97UgsPG%3DvVoZ5bj9pP_4BxnO-6DYA%40mail.gmail.com
Regards,
Vignesh
