Request a Demo
Home   >   mailing lists

pg_dump crash due to incomplete ordering of DO_SUBSCRIPTION_REL objects - Mailing list pgsql-hackers

From vignesh C
Subject pg_dump crash due to incomplete ordering of DO_SUBSCRIPTION_REL objects
Date
Msg-id CALDaNm2x3rd7C0_HjUpJFbxpAqXgm=QtoKfkEWDVA8h+JFpa_w@mail.gmail.com
Whole thread Raw
Responses Re: pg_dump crash due to incomplete ordering of DO_SUBSCRIPTION_REL objects
List pgsql-hackers
Tree view 
Hi,

While verifying upgrade of subscriber instance, I noticed pg_dump
crash caused by incomplete sorting logic for DO_SUBSCRIPTION_REL
objects in DOTypeNameCompare(). When multiple subscription–relation
entries belong to the same subscription, the comparison does not
establish a complete ordering. In this case, the comparison falls
through to the generic assertion path. The attached patch fixes this
by extending the comparison for DO_SUBSCRIPTION_REL objects to include
deterministic ordering keys. After the subscription name comparison,
entries are ordered by the referenced table's schema name and then by
table name.

This issue has started failing after commit:
commit 0decd5e89db9f5edb9b27351082f0d74aae7a9b6
Sort dump objects independent of OIDs, for the 7 holdout object types.

This can be reproduced by having logical replication setup with
subscription subscribing to few tables.

Thanks,
Vignesh
Attachment

pgsql-hackers by date:

Previous
From: "Euler Taveira"
Date:
Subject: Re: create table like including storage parameter
Next
From: Thomas Munro
Date:
Subject: Re: [PATCH] Fix severe performance regression with gettext 0.20+ on Windows