On Fri, 9 Aug 2024 at 12:40, Peter Smith <smithpb2250@gmail.com> wrote:
>
> Hi Vignesh, here are my review comments for the sequences docs patch
> v20240808-0004.
>
> ======
> doc/src/sgml/logical-replication.sgml
>
> The new section content looked good.
>
> Just some nitpicks including:
> - renamed the section "Replicating Sequences"
> - added missing mention about how to publish sequences
> - rearranged the subscription commands into a more readable list
> - some sect2 titles were very long; I shortened them.
> - added <warning> markup for the sequence definition advice
> - other minor rewording and typo fixes
I have retained the caveats section for now, I will think more and
remove it if required in the next version.
The rest of the comments are fixed in the v20240809 version patch
attached at [1].
[1] - https://www.postgresql.org/message-id/CALDaNm0LJCtGoBCO6DFY-RDjR8vxapW3W1f7%3D-LSQx%3DXYjqU%3Dw%40mail.gmail.com
Regards,
Vignesh
