Postgres Pro
Downloads
Home   >   mailing lists

Re: Added schema level support for publication. - Mailing list pgsql-hackers

From vignesh C
Subject Re: Added schema level support for publication.
Date
Msg-id CALDaNm27bs40Rxpy4oKfV97UgsPG=vVoZ5bj9pP_4BxnO-6DYA@mail.gmail.com
Whole thread Raw
In response to Re: Added schema level support for publication.  (Amit Kapila <amit.kapila16@gmail.com>)
Responses Re: Added schema level support for publication.  (Amit Kapila <amit.kapila16@gmail.com>)
Re: Added schema level support for publication.  (Greg Nancarrow <gregn4422@gmail.com>)
List pgsql-hackers
Tree view 
On Tue, Aug 31, 2021 at 6:28 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> >
> > I have made these changes at the v23 patch attached at [1].
> >
>
> *
> +/*
> + * Invalidate the relations.
> + */
> +static inline void
> +InvalidatePublicationRels(List *relids)
>
> I don't see the need to make this an inline function.

Modified

> * On similar lines, the code in function
> GetPubPartitionOptionRelations seems to be extracted from existing
> function GetPublicationRelations(). Can't we move it into the 0001
> patch?

Modified

Thanks for the comments, the attached v24 patch has the changes for the same.

Regards,
Vignesh
Attachment

pgsql-hackers by date:

Previous
From: Dean Rasheed
Date:
Subject: Re: Numeric x^y for negative x
Next
From: vignesh C
Date:
Subject: Re: Added schema level support for publication.