Re: Logical Replication of sequences - Mailing list pgsql-hackers

From vignesh C
Subject Re: Logical Replication of sequences
Date
Msg-id CALDaNm1c7TuwHA0ruuBHWJBBCAB=KVhH1LkPu6jBuBDV96=7xQ@mail.gmail.com
Whole thread Raw
In response to Re: Logical Replication of sequences  (shveta malik <shveta.malik@gmail.com>)
List pgsql-hackers
On Thu, 25 Sept 2025 at 12:23, shveta malik <shveta.malik@gmail.com> wrote:
>
> sequencesync_list_invalidate_cb():
> 5)
>
> + /* invalidate all entries */
> + hash_seq_init(&status, sequences_to_copy);
> + while ((entry = (LogicalRepSequenceInfo *) hash_seq_search(&status)) != NULL)
> + entry->entry_valid = false;
>
> Can you please elaborate when this case can be hit? I see such logic
> in all such invalidation functions registered with
> CacheRegisterRelcacheCallback(), but could not find any relevant
> comment.

I noticed this could happen in cases like:
create publication for all tables;
alter publication on many relations;

but there might be more apart from this

Rest of the comments were addressed.
The attached patch has the changes for the same.

Regards,
Vignesh

Attachment

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: [PATCH] GROUP BY ALL
Next
From: Guillaume Lelarge
Date:
Subject: Re: [BUG] temporary file usage report with extended protocol and unnamed portals