Re: Distinguish publication exclusions in object addresses - Mailing list pgsql-hackers

From vignesh C
Subject Re: Distinguish publication exclusions in object addresses
Date
Msg-id CALDaNm18azW2vciTHd=5xesJ-xMkty8CKutGKxCkGZUZd++8dg@mail.gmail.com
Whole thread
In response to Re: Distinguish publication exclusions in object addresses  (vignesh C <vignesh21@gmail.com>)
Responses Re: Distinguish publication exclusions in object addresses
Re: Distinguish publication exclusions in object addresses
List pgsql-hackers
On Wed, 16 Sept 2026 at 14:26, vignesh C <vignesh21@gmail.com> wrote:
>
> On Wed, 16 Sept 2026 at 13:57, Chao Li <li.evan.chao@gmail.com> wrote:
> >
> > I don’t think the fix would add much complexity, please see the attached diff I tried. This error message is shown
tousers, so I think improving it is worthwhile. 
>
> Agreed. I had initially thought the additional code complexity was not
> worthwhile. Since this is a user-facing error message, I agree that
> making it more specific is worthwhile. Thanks, I have merged the
> changes.
> The attached v5 version patch has the changes for the same.

While reviewing the patch further, I noticed that the Assert in
get_object_address_publication_rel() can be placed immediately after
the variable declarations, rather than after the subsequent checks.
The attached v6 patch includes this change.

Regards,
Vignesh

Attachment

pgsql-hackers by date:

Previous
From: "Alberto Piai"
Date:
Subject: Re: Unexpected reindex when altering column types for partitioned tables
Next
From: Antonin Houska
Date:
Subject: Re: REPACK enhancements