On Thu, 1 May 2025 at 08:46, vignesh C <vignesh21@gmail.com> wrote:
>
> On Tue, 29 Apr 2025 at 06:15, Peter Smith <smithpb2250@gmail.com> wrote:
> >
> > Hi Vignesh.
> >
> > Some trivial review comments for DOCS patch v20250428-0005.
> >
> > ======
> > doc/src/sgml/logical-replication.sgml
> >
> > 1.
> > + Publications may currently only contain tables or sequences. Objects must be
> > + added explicitly, except when a publication is created using
> > + <literal>FOR TABLES IN SCHEMA</literal>, or <literal>FOR ALL
> > TABLES</literal>,
> > + or <literal>FOR ALL SEQUENCES</literal>. Unlike tables, the current state of
> > + sequences may be synchronised at any time. For more information, refer to
> > + <xref linkend="logical-replication-sequences"/>.
> > </para>
> >
> > AFAIK the PostgreSQL documentation uses US spelling:
> >
> > /synchronised/synchronized/
> >
> > ~~~
> >
> > 2.
> > + Incremental sequence changes are not replicated. Although the data in
> > + serial or identity columns backed by sequences will of course be
> > + replicated as part of the table, the sequences themselves do not replicate
> > + ongoing changes. On the subscriber, a sequence will retain the last value
> >
> > I didn't think that you needed to say "of course" here.
>
> Thanks for the comments, the updated patch has the changes for the same.
There was one pending open comment #6 from [1]. This has been
addressed in the attached patch.
[1] -
https://www.postgresql.org/message-id/OSCPR01MB14966DA8CB749A0D4E9F3F7A7F50E2%40OSCPR01MB14966.jpnprd01.prod.outlook.com
Regards,
Vignesh
