Use XLogRecPtrIsValid() instead of negated XLogRecPtrIsInvalid - Mailing list pgsql-hackers

From vignesh C
Subject Use XLogRecPtrIsValid() instead of negated XLogRecPtrIsInvalid
Date
Msg-id CALDaNm16knMFtcqyAG3XYSkyagmVXfhaR0T=hau8UTAU0+eLQQ@mail.gmail.com
Whole thread
Responses Re: Use XLogRecPtrIsValid() instead of negated XLogRecPtrIsInvalid
List pgsql-hackers
Hi,

This small cleanup patch updates src/bin/pg_waldump/archive_waldump.c
to use the recently introduced XLogRecPtrIsValid() helper instead of
negating XLogRecPtrIsInvalid(). The current code uses double-negative
checks such as:
Assert(!XLogRecPtrIsInvalid(privateInfo->startptr));
if (!XLogRecPtrIsInvalid(privateInfo->endptr))

This patch changes them to:
Assert(XLogRecPtrIsValid(privateInfo->startptr));
if (XLogRecPtrIsValid(privateInfo->endptr))

This improves readability without changing behavior. The attached
patch has the changes for the same.

Regards,
Vignesh

Attachment

pgsql-hackers by date:

Previous
From: Shlok Kyal
Date:
Subject: Support EXCEPT for ALL SEQUENCES publications
Next
From: Michael Paquier
Date:
Subject: Re: Fix pgstat_database.c to honor passed database OIDs