On Thu, 26 Feb 2026 at 19:41, Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Wed, Feb 25, 2026 at 10:43 PM Shlok Kyal <shlok.kyal.oss@gmail.com> wrote:
> >
> > I have also split the patch 0002 to 0002 and 0003
> > 0001 - Support CREATE PUBLICATION ... EXCEPT TABLE syntax
> >
>
> Few comments:
> =============
> *
> * pub_all_obj_type is one of:
> *
> - * TABLES
> + * TABLES [EXCEPT [TABLE] ( table [, ...] )]
> As per above syntax in gram.y, [TABLE] is optional but won't it be
> confusing when we also support sequences? Then we need to identify
> whether the object given in EXCEPT list is table or sequence. So, I
> think it is better to keep TABLE as non-optional.
>
> * Can we have one test related to INHERITS for actual replication
> unless it is already there?
Thanks for the comments, these comments are addressed in the v52
version patch attached.
Also the comments from [1] are addressed in the same.
[1] - https://www.postgresql.org/message-id/CAA4eK1JrqoPvrFxZEO2rB%3D-jXK1BQdJZz2_2oeZqCQR3GRWC2g%40mail.gmail.com
Regards,
Vignesh