Re: Typos and inconsistencies in code - Mailing list pgsql-hackers

From vignesh C
Subject Re: Typos and inconsistencies in code
Date
Msg-id CALDaNm0hLN=yjqnQFOS9wdtr4Npsx1i2fc9OB3m5tA22m=kDUg@mail.gmail.com
Whole thread Raw
In response to Re: Typos and inconsistencies in code  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On Wed, Oct 30, 2019 at 6:35 AM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Tue, Oct 29, 2019 at 05:27:20PM +0530, vignesh C wrote:
> > I have attached the updated patch with the fixes.
>
> The changes in rangetypes_gist.c are not correct, the usual pattern to
> add an "s" after the structure name is quite common when referring to
> multiple elements.  We could perhaps use "put-your-struct entries"
> instead, but I have seen the pattern of HEAD quite a lot as well (see
> also for example mcv.c with SortItem that is a file your patch
> touches).
>
> A comment indentation was wrong in detoast.c, not the fault of this
> patch but I have fixed it at the same time.
>
Thanks for pushing the changes Michael.

Regards,
Vignesh
EnterpriseDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Kyotaro Horiguchi
Date:
Subject: Re: Problem with synchronous replication
Next
From: vignesh C
Date:
Subject: Re: PATCH: logical_work_mem and logical streaming of largein-progress transactions