Re: Use XLogRecPtrIsValid() instead of negated XLogRecPtrIsInvalid - Mailing list pgsql-hackers

From vignesh C
Subject Re: Use XLogRecPtrIsValid() instead of negated XLogRecPtrIsInvalid
Date
Msg-id CALDaNm0MO0qSwN2tbEyzogocdV4COwGQs9_OD7r+P4GaWnac=g@mail.gmail.com
Whole thread
In response to Re: Use XLogRecPtrIsValid() instead of negated XLogRecPtrIsInvalid  (Fujii Masao <masao.fujii@gmail.com>)
Responses Re: Use XLogRecPtrIsValid() instead of negated XLogRecPtrIsInvalid
List pgsql-hackers
On Thu, 16 Apr 2026 at 09:42, Fujii Masao <masao.fujii@gmail.com> wrote:
>
> On Mon, Apr 13, 2026 at 4:10 PM vignesh C <vignesh21@gmail.com> wrote:
> > I felt these also should be updated, the attached v2 version patch
> > includes the changes for the same.
>
> Thanks for updating the patch!
>
> -       applyPtr = (latestApplyPtr == InvalidXLogRecPtr) ?
> +       applyPtr = (XLogRecPtrIsInvalid(latestApplyPtr)) ?
>
> XLogRecPtrIsValid() should be used here, instead?

Yes, that seems better, the attached v3 version patch has the changes
for the same.

Regards,
Vignesh

Attachment

pgsql-hackers by date:

Previous
From: Nisha Moond
Date:
Subject: Re: Support EXCEPT for TABLES IN SCHEMA publications
Next
From: Mihail Nikalayeu
Date:
Subject: Re: Adding REPACK [concurrently]