Re: Added schema level support for publication. - Mailing list pgsql-hackers

From vignesh C
Subject Re: Added schema level support for publication.
Date
Msg-id CALDaNm0BSy2tz6jZ-OSnmkYeosT7LQ=-rsRHP1M9-eMM7tm2gA@mail.gmail.com
Whole thread Raw
In response to Re: Added schema level support for publication.  (Greg Nancarrow <gregn4422@gmail.com>)
List pgsql-hackers
On Thu, Jun 24, 2021 at 2:12 PM Greg Nancarrow <gregn4422@gmail.com> wrote:
>
> On Thu, Jun 24, 2021 at 4:41 PM tanghy.fnst@fujitsu.com
> <tanghy.fnst@fujitsu.com> wrote:
> >
> > I applied your V7* patch and complied it. The following warnings came out, please take a look.
> >
>
> I encountered the following warnings when building with the v7 patches applied:
> (looks like missing #include "catalog/objectaddress.h")
>
> pg_prewarm.c:109:29: warning: implicit declaration of function
> ‘get_relkind_objtype’; did you mean ‘get_element_type’?
> [-Wimplicit-function-declaration]
>    aclcheck_error(aclresult,
> get_relkind_objtype(rel->rd_rel->relkind), get_rel_name(relOid));
>                              ^~~~~~~~~~~~~~~~~~~
>                              get_element_type
>
> heap_surgery.c:391:9: warning: implicit declaration of function
> ‘get_relkind_objtype’; did you mean ‘get_publication_type’?
> [-Wimplicit-function-declaration]
>          get_relkind_objtype(rel->rd_rel->relkind),
>          ^~~~~~~~~~~~~~~~~~~
>          get_publication_type
>
> pgrowlocks.c:136:29: warning: implicit declaration of function
> ‘get_relkind_objtype’ [-Wimplicit-function-declaration]
>    aclcheck_error(aclresult, get_relkind_objtype(rel->rd_rel->relkind),
>

Thanks for reporting these warnings, I have fixed this in the v8 patch attached at [1].

Regards,
Vignesh

pgsql-hackers by date:

Previous
From: Fabien COELHO
Date:
Subject: Re: pgbench using COPY FREEZE
Next
From: vignesh C
Date:
Subject: Re: Added schema level support for publication.