On Wed, Apr 8, 2026 at 8:57 PM Andres Freund <andres@anarazel.de> wrote:
>
> Hi,
>
> On 2026-04-08 08:51:30 +0200, Jakub Wartak wrote:
> > For some reason I've ended up using -Dsegsize_blocks=4 and I've started
> > getting ninja test errors after getting back from vacation leave like
> > below (so this test was included only since then):
>
> It's IIRC not the only test that fails if you do that.
>
>
> > .cirrus file show usage of segsize_blocks=6, and also 8 works fine without
> > errors, so it's just nuisance on my side, but it took some minutes for me
> > to realize this and I'll just ask maybe we should just block usage of
> > RELSEG_SIZE < 6 blocks in meson/configure? (patch attached)
>
> -1. I find it quite useful for testing some edge cases to be able to
> configure with less.
>
> If you really care, I'd be ok with a patch that makes the relevant test_aio
> tests errors out with if it's set to a too low value...
Ah, true, with segsize_blocks=2 I've got failures in basebackup,
amcheck, test_aio.
I'm not going into that dragons' den. Ok, so maybe it would be useful to just
issue some sort of warning about that some test may fail when using value less
than 6?
-J.
