Re: bug: pg_dumpall with --data-only and --clean options is giving an error after some dump - Mailing list pgsql-hackers

From Mahendra Singh Thalor
Subject Re: bug: pg_dumpall with --data-only and --clean options is giving an error after some dump
Date
Msg-id CAKYtNAp2L2nnC-7vdkEkkccDLmv22BH0wJyAzd3Z-M2ugYSEKQ@mail.gmail.com
Whole thread Raw
In response to Re: bug: pg_dumpall with --data-only and --clean options is giving an error after some dump  (Álvaro Herrera <alvherre@kurilemu.de>)
List pgsql-hackers
Thanks Andrew, Álvaro and Srinath for the review and feedback.

> 1) maybe match the pg_dumpall comment with the pg_dump comment.

I took this comment from pg_restore so i am keeping this same as pg_restore.

> 2) please fix the indentation using pgindent
> --
> Thanks,
> Srinath Reddy Sadipiralla
> EDB: https://www.enterprisedb.com/

Fixed.

On Sun, 15 Mar 2026 at 17:41, Álvaro Herrera <alvherre@kurilemu.de> wrote:
>
> Hi,
>
> On 2026-Mar-15, Andrew Dunstan wrote:
>
> > On 2026-03-14 Sa 3:18 PM, Mahendra Singh Thalor wrote:
> >
> > > I was doing some tests with pg_dump, pg_dumpall and pg_restore tools.
> > > With "pg_dumpall --data-only --clean", we are reporting an error after
> > > dumping some data.
> >
> > Hmm, this looks like behaviour that goes a long way back. Should we
> > backpatch this fix?
>
> IMO it would make sense to do so.
>
> --
> Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/

As per suggestions, I made patches till PG14.

Here, I am attaching updated patches.

--
Thanks and Regards
Mahendra Singh Thalor
EnterpriseDB: http://www.enterprisedb.com

Attachment

pgsql-hackers by date:

Previous
From: Junwang Zhao
Date:
Subject: Re: More speedups for tuple deformation
Next
From: "Jelte Fennema-Nio"
Date:
Subject: Re: Don't use the deprecated and insecure PQcancel in our frontend tools anymore