> Thanks, Álvaro, for your continued help with this. > > I have attached v11 patches that use all of the fixes from your > review.patch.txt.
OK, thanks, I pushed 0001 now.
I think you could claim that some routines currently in src/backend/commands/tablespace.c logically belong in the new file, but unless you want to take on the task of moving a lot of other routines under commands/ to their respective catalog/ file, then I think it's more or less fine as is.
To be clear, I do not intend to do anything with your 0002 patch [for now]. I'm going to let Andrew take these DDL-producing functions in his hands. Here I'm just posting your 0002 again, to make the cfbot happy.
Thanks
-- Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/ "Nunca se desea ardientemente lo que solo se desea por razón" (F. Alexandre)
OK, thanks very much, Álvaro.
If you are OK with the current state of the patch, then I am happy to not move any more functions into their respective catalog/ files. My co-author, Nishant, should feel free to offer his opinion here too.
