Request a Demo
Home   >   mailing lists

Re: [PATCH] Add pg_get_tablespace_ddl() function to reconstruct CREATE TABLESPACE statement - Mailing list pgsql-hackers

From Manni Wood
Subject Re: [PATCH] Add pg_get_tablespace_ddl() function to reconstruct CREATE TABLESPACE statement
Date
Msg-id CAKWEB6ovQP+649hE9B=X+ZRbXR28C=3YwWwhD6a3aOBykYp8_A@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Add pg_get_tablespace_ddl() function to reconstruct CREATE TABLESPACE statement  (Jim Jones <jim.jones@uni-muenster.de>)
Responses Re: [PATCH] Add pg_get_tablespace_ddl() function to reconstruct CREATE TABLESPACE statement
List pgsql-hackers
Tree view


On Fri, Nov 7, 2025 at 6:03 PM Jim Jones <jim.jones@uni-muenster.de> wrote:


On 08/11/2025 00:38, Manni Wood wrote:
> Alas, the build https://commitfest.postgresql.org/patch/6175/ <https://
> commitfest.postgresql.org/patch/6175/> now fails, and I cannot reproduce
> on my machine. Obviously there will be a v9...

You forgot the declaration for build_tablespace_ddl_string[1]:

ruleutils.c:13755:1: warning: no previous prototype for
‘build_tablespace_ddl_string’ [-Wmissing-prototypes]
13755 | build_tablespace_ddl_string(const Oid tspaceoid)
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~

Best, Jim

1 - https://cirrus-ci.com/task/4855404196265984?logs=build#L1911


Thank you very much, Jim. Serves me right for looking at the error at the end of the logs rather than the warning in the middle.

v9 is attached.
--
-- Manni Wood EDB: https://www.enterprisedb.com
Attachment

pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Extra blank line in StrategyGetBuffer
Next
From: Manni Wood
Date:
Subject: Re: [PATCH] Add pg_get_tablespace_ddl() function to reconstruct CREATE TABLESPACE statement