Postgres Pro
Downloads
Home   >   mailing lists

Re: Extract numeric filed in JSONB more effectively - Mailing list pgsql-hackers

From Andy Fan
Subject Re: Extract numeric filed in JSONB more effectively
Date
Msg-id CAKU4AWrXxxY_Qt_L0VXy-Uuv1yvvnvkOGC2VyLpHF=gpeQa1Eg@mail.gmail.com
Whole thread Raw
In response to Re: Extract numeric filed in JSONB more effectively  (Pavel Stehule <pavel.stehule@gmail.com>)
Responses Re: Extract numeric filed in JSONB more effectively
List pgsql-hackers
Tree view
Hi Pavel: 

Thanks for the code level review!
 

I am looking on your patch, and the message

+
+ default:
+ elog(ERROR, "cast jsonb field to %d is not supported.", targetOid);

is a little bit messy. This case should not be possible, because it is filtered by jsonb_cast_is_optimized. So the message should be changed or it needs a comment.

Yes, the double check is not necessary,  that is removed in the attached v4 patch. 


--
Best Regards
Andy Fan
Attachment

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: [PoC] pg_upgrade: allow to upgrade publisher node
Next
From: Julien Rouhaud
Date:
Subject: Re: [PoC] pg_upgrade: allow to upgrade publisher node