I think we could have use some different grey colour shade for SlickGrid headers from wcDocker panel, It does not look bad but as a end user I'm not able to differentiate between them now, please refer screenshot attached.
On Wed, Jun 7, 2017 at 9:01 PM, Dave Page <dpage@pgadmin.org> wrote:
Thanks, applied.
On Wed, Jun 7, 2017 at 3:48 PM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote: > Hi > > I have used classes 'bg-gray-2 border-gray-3' for styling header and footer > of properties panel which are also used in other places. > > Please find attached patch. > > > On Wed, Jun 7, 2017 at 6:59 PM, Robert Eckhardt <reckhardt@pivotal.io> > wrote: >> >> Thank you. >> >> -- Rob >> >> On Wed, Jun 7, 2017 at 9:28 AM, Surinder Kumar >> <surinder.kumar@enterprisedb.com> wrote: >>> >>> Sure I will send. >>> >>> On Wed, Jun 7, 2017 at 6:54 PM, Dave Page <dpage@pgadmin.org> wrote: >>>> >>>> On Wed, Jun 7, 2017 at 2:22 PM, Surinder Kumar >>>> <surinder.kumar@enterprisedb.com> wrote: >>>> > Hi >>>> > >>>> > With the latest pull, I found: >>>> > The header color of Properties panel disappears and background color >>>> > of >>>> > footer area in Edit Properties panel is changed. >>>> >>>> Oh, I missed that :-(. Can you come up with a quick fix using the new >>>> classes? >>>> >>>> -- >>>> Dave Page >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>>> EnterpriseDB UK: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>> >>> >> >
From:
Surinder Kumar Date: Subject:
[pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialogbox should act like "Cancel" button