On Tue, Jul 18, 2017 at 1:21 AM, Shirley Wang <swang@pivotal.io> wrote:
Hi!
I can't seem to get the patch to completely work on my computer, only the close icon shows up plus the dialog and success/error messages, but here are some comments:
Because we are just cancelling the active running query, so if the start of the session is 'Active' when you cancel it will simply goto 'Idle' stat.
+1 to Dave's comment about refreshing after the cancel operation
I'll fix this.
- We're working on a patch for updating alerts in the Dashboard tab which updates the grays in the Database activities panel and changes the border around the refresh button and search bar to 1px. This hasn't been submitted yet but just a heads up as you work on the alignment.
- Something to consider is how a super user will identify which session should be closed. Is that information there?
I think super user can cancel everything except main connection session & as Dave mentioned in previous email that background workers in PG10.
- Are there sessions that should never be closed? If so, do they also need close buttons? (Probably not, because that will lead the user to an error message, which is not fun)
In Backgrid, we can not exclude specific column from certain rows if it renders in one row then it will render for every row in the grid, What we can do is, it will throw an error when user is not eligible to cancel the active running query.
- Perhaps this is a good feature to review with Chethana! :)
