Re: PATCH: Fixed Textarea control template [pgAdmin4] - Mailing list pgadmin-hackers

From Murtuza Zabuawala
Subject Re: PATCH: Fixed Textarea control template [pgAdmin4]
Date
Msg-id CAKKotZS-OWjiJ5ZSOLpOmoFd92xy2CSyaV=4mpZz15_UZxvGaA@mail.gmail.com
Whole thread Raw
In response to Re: PATCH: Fixed Textarea control template [pgAdmin4]  (Ashesh Vashi <ashesh.vashi@enterprisedb.com>)
List pgadmin-hackers
Hi,

I have sent updated patch to include default rows arguments into sql field control.

Regards,
Murtuza 

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Fri, Mar 11, 2016 at 2:03 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
On Fri, Mar 11, 2016 at 1:59 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA updated patch for mentioned issue.
Can please you describe, why did you sent the updated path, what was missing in the previous patch?

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company





--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Fri, Mar 11, 2016 at 1:08 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA updated patch to fix an issue in textarea template, if we do not provide default rows then control then it fails to render it (issue with yesterday's Arun changes), Causing Sql-Feild Control to break which uses textarea to render code mirror control.


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company




--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers



pgadmin-hackers by date:

Previous
From: Ashesh Vashi
Date:
Subject: Re: PATCH: Fixed Textarea control template [pgAdmin4]
Next
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Update ACL parsing for tablespaces to use newer infra