Re: [pgAdmin4][Patch#2897] Add support for keyboard navigation in Debugger - Mailing list pgadmin-hackers

From Murtuza Zabuawala
Subject Re: [pgAdmin4][Patch#2897] Add support for keyboard navigation in Debugger
Date
Msg-id CAKKotZRoYVZRPU9_p-oKUcCqkmDopPcuiM+FNsnQ8xRF405B1A@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin4][Patch#2897] Add support for keyboard navigation in Debugger  (Dave Page <dpage@pgadmin.org>)
Responses Re: [pgAdmin4][Patch#2897] Add support for keyboard navigation in Debugger
List pgadmin-hackers
Hi Dave,

Please find updated patch with docs and JS tests.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Mon, Jan 22, 2018 at 4:02 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

This seems to be missing documentation updates. I would also expect to see some Jasmine unit tests for some/all of the new JS functions.

On Tue, Jan 16, 2018 at 1:29 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch to add keyboard navigation in Debugger module via Tab/Shift-Tab key.
RM#2897

Also fixed the issue where user was not able to update values in variable's panel while debugging.
RM#2981

Currrently we have execution related shortcuts using accesskey, 
Shortcuts (Execution related)
----------------------------------
<accesskey> + i  = Step in
<accesskey> + o = Step over
<accesskey> + c = Continue/Restart
<accesskey> + t = Toggle breakpoint
<accesskey> + x = Clear all breakpoints
<accesskey> + s = Stop 

Shortcuts (Panel navigation related)
----------------------------------
Alt + Shift + Right Arrow
Alt + Shift + Left Arrow

Edit/Enter values in Grid (Parameter & Local variables panel's)
-------------------------------------------------------------
Alt + Shift + g

Please review.

Note: As of now inner panel's are not getting focused on Tab/Shift-Tab keys but once RM#2895 patch gets committed it will start working automatically as it's inherited code which will add tabindex tag automatically on each newly created wcDocker panel.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment

pgadmin-hackers by date:

Previous
From: Harshal Dhumal
Date:
Subject: Re: Module-wise Keyboard preferences
Next
From: Dave Page
Date:
Subject: Re: [pgadmin4]{Patch] Display GreenPlum partitions and correct SQL onSQL Tab