Checklist before sending patch to pgAdmin4-hackers - Mailing list pgadmin-hackers

From Murtuza Zabuawala
Subject Checklist before sending patch to pgAdmin4-hackers
Date
Msg-id CAKKotZQtzxNxmJBVq_=x==p8fwgxx04n=yWdTRZma0MX4qfnRw@mail.gmail.com
Whole thread Raw
List pgadmin-hackers
Hello,

Here is the common checklist to follow before sending patch to pgAdmin4-hackers group,

1) Get the latest pull from master branch.

2) Apply your patch and check if applies successfully on the latest code.

3) Check for PEP8 issues
- activate virtual env
- cd ../web
- yarn run pep8

4) Run regression test
python regression/runtests.py 

- To run only UI/feature tests
python regression/runtests.py --pkg feature_tests 

- To run regression test (without UI/Feature tests)
python regression/runtests.py --exclude feature_tests 

5) Run Jasmine tests
- activate virtual env
- cd ../web
yarn run test:karma-once

6) Make sure to add or update help docs and screenshot(s) if you have added any new feature or changed any existing one.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Joao De Almeida Pereira
Date:
Subject: Re: AttributeError
Next
From: Akshay Joshi
Date:
Subject: Re: [pgadmin][patch] [GreenPlum] When user press Explain Plan andExplain analyze plan an error is displayed