Suggestion on "External types" sql query in pgAdmin3 - Mailing list pgadmin-hackers

From Murtuza Zabuawala
Subject Suggestion on "External types" sql query in pgAdmin3
Date
Msg-id CAKKotZQTOHFskPE4VKiYrMpo8_aFumkyNOM-ji-Mqc3F=Snwjg@mail.gmail.com
Whole thread Raw
Responses Re: Suggestion on "External types" sql query in pgAdmin3
List pgadmin-hackers
Hi All,

Below is the query to fetch Input/Output/Send/Receive/Analyze functions while creating new external type (create mode) in pgAdmin3,

With latest git pull [File: pgadmin/dlg/dlgType.cpp] [Line: 548],

Current:
SELECT proname, nspname
FROM (
SELECT proname, nspname, max(proargtypes[0]) AS arg0, max(proargtypes[1]) AS arg1
FROM pg_proc p
JOIN pg_namespace n ON n.oid=pronamespace
GROUP BY proname, nspname
HAVING count(proname) = 1 ) AS uniquefunc
WHERE arg0 <> 0 AND arg1 = 0;

Modified:
SELECT proname, nspname
FROM (
SELECT proname, nspname, max(proargtypes[0]) AS arg0, max(proargtypes[1]) AS arg1
FROM pg_proc p
JOIN pg_namespace n ON n.oid=pronamespace
GROUP BY proname, nspname
HAVING count(proname) = 1 ) AS uniquefunc
WHERE arg0 <> 0 AND arg1 IS NULL;


When I changed where condition to 'arg1 IS NULL' from 'arg1 = 0', All combo boxes are populated.

Can someone please confirm if it's correct?

Please review attached patch for the same.


Regards,
Murtuza
Attachment

pgadmin-hackers by date:

Previous
From: Khushboo Vashi
Date:
Subject: Re: pgAdmin4 PATCH: Domain Module
Next
From: Dave Page
Date:
Subject: Re: Fix PSQL Console plugin for OS X