Postgres Pro
Downloads
Home   >   mailing lists

Re: pgAdmin 4 commit: Fixed an issue where the validation error message is - Mailing list pgadmin-hackers

From Murtuza Zabuawala
Subject Re: pgAdmin 4 commit: Fixed an issue where the validation error message is
Date
Msg-id CAKKotZQHFgKwkJQj3d+=VVnxmF_EgnT-26i6WO9zEJ86+x+DTQ@mail.gmail.com
Whole thread Raw
In response to Re: pgAdmin 4 commit: Fixed an issue where the validation error message is  (Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>)
Responses Re: pgAdmin 4 commit: Fixed an issue where the validation error message is  (Rahul Shirsat <rahul.shirsat@enterprisedb.com>)
List pgadmin-hackers
Tree view
Hello,

Another observation,

+        if(msg && handler) {
+          msg = msg || _.values(handler.errorModel.attributes)[0];
+
+          handler.trigger('pgadmin-session:model:invalid', msg, handler);
+          $(parentTr).addClass('error-in-grid');
+        }
+        return this;
+      }, 120);
+    },

Here we are only making the model invalid, there is no logic to make it valid again.


On Thu, Dec 3, 2020 at 11:09 AM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hello,

What is the reason for adding delay setTimeout(<func>, 120)?

This is causing issues in automation testing and makes buttons enable/disable with slight delay.

--
Regards,
Murtuza Zabuawala
EDB
POWER TO POSTGRES


On Fri, Oct 30, 2020 at 3:10 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Fixed an issue where the validation error message is shown twice. Fixes #5736

Branch
------
master

Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=183c83f0d2b2cb8dd33f9e8c41a030bc4cdaa4b2
Author: Rahul Shirsat <rahul.shirsat@enterprisedb.com>

Modified Files
--------------
docs/en_US/release_notes_4_28.rst          |  1 +
web/pgadmin/browser/static/js/datamodel.js | 75 +++++++++++++++++++++++++++++-
web/pgadmin/static/js/backform.pgadmin.js  | 24 ++++------
web/pgadmin/static/scss/_alert.scss        |  6 +++
4 files changed, 90 insertions(+), 16 deletions(-)

pgadmin-hackers by date:

Previous
From: Murtuza Zabuawala
Date:
Subject: Re: pgAdmin 4 commit: Fixed an issue where the validation error message is
Next
From: Rahul Shirsat
Date:
Subject: Re: pgAdmin 4 commit: Fixed an issue where the validation error message is