Re: Add ldapservice connection parameter - Mailing list pgsql-hackers

Hi,

Noticed 1 variable that was unused during non-LDAP builds. Tested
locally and did not see the error/warning. Also some minor cleanup
(comments, definition placement, etc).

Thanks,
Andrew Jackson

On Mon, Jan 12, 2026 at 5:53 PM Andrew Jackson
<andrewjackson947@gmail.com> wrote:
>
> Steven and Roman, Thank you for the review.
>
> Here is an updated patch that addresses both of these issues.
>
> On Mon, Jan 12, 2026 at 4:06 AM Roman Khapov <rkhapov@yandex-team.ru> wrote:
> >
> > Hi!
> >
> > Thanks for your patch!
> >
> > Adding to the one Steven wrote, I noticed one typo in the patch:
> >
> > @@ -2337,7 +2337,7 @@ postgresql://%2Fvar%2Flib%2Fpostgresql/dbname
> >        <term><literal>ldapservice</literal></term>
> >        <listitem>
> >         <para>
> > -        This option specifies an LDAP query that can be used to reference connection paremeters
> > +        This option specifies an LDAP query that can be used to reference connection parameters
> >          stored in an LDAP server. This functionality is described in more detail in <xref linkend="libpq-ldap"/>.
> >          </para>
> >
> > paremeters -> parameters
> >
> > --
> > Best regards,
> > Roman Khapov