Re: pg_dump multi VALUES INSERT - Mailing list pgsql-hackers

From David Rowley
Subject Re: pg_dump multi VALUES INSERT
Date
Msg-id CAKJS1f8SZqFcOSws4i4BwZ-4i9+Ki9_n40ta+_WY0=OPodAUMQ@mail.gmail.com
Whole thread Raw
In response to Re: pg_dump multi VALUES INSERT  (Fabien COELHO <coelho@cri.ensmp.fr>)
List pgsql-hackers
On Sun, 3 Feb 2019 at 21:00, Fabien COELHO <coelho@cri.ensmp.fr> wrote:
> >> There is a test, that is good! Charater "." should be backslashed in the
> >> regexpr.
> >
> > Yeah, you're right.   I wonder if we should fix the test of them in
> > another patch.
>
> From a software engineering perspective, I'd say that a feature and its
> tests really belong to the same patch.

I meant to say "fix the rest" if them, not "the test of them".


-- 
 David Rowley                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services


pgsql-hackers by date:

Previous
From: Andrew Gierth
Date:
Subject: Re: Early WIP/PoC for inlining CTEs
Next
From: Michael Paquier
Date:
Subject: Re: [PATCH] Pass COPT and PROFILE to CXXFLAGS as well