Re: Mismatch for connection key/value pair between documentation and code? - Mailing list pgsql-docs

From David G. Johnston
Subject Re: Mismatch for connection key/value pair between documentation and code?
Date
Msg-id CAKFQuwb7ScOPsFqV281m2SBumso7oYN+HWFKDeFrGMLQZA9FRg@mail.gmail.com
Whole thread Raw
In response to Mismatch for connection key/value pair between documentation and code?  (PG Doc comments form <noreply@postgresql.org>)
List pgsql-docs
On Monday, July 15, 2024, PG Doc comments form <noreply@postgresql.org> wrote:
The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/16/libpq-connect.html
Description:


For the following document regarding connect string, it is not aligned with
the code.
https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNSTRING

e.g. Timeout for connection

"connect_timeout
Maximum time to wait while connecting, in seconds (write as a decimal
integer, e.g., 10).

 
However in the code:
https://github.com/npgsql/npgsql/blob/docs/src/Npgsql/NpgsqlConnectionStringBuilder.cs,
starting L789  to L812 (latest version when I raise this ticket).
 

The name is Timeout instead of connect_timeout, and there's no logic
regarding 2 second check


Probably this third-party module is not using the libpq API.  Or at minimum not that aspect of the API.

David J.

pgsql-docs by date:

Previous
From: "David G. Johnston"
Date:
Subject: Re: 13.2.2. Repeatable Read Isolation Level #
Next
From: Laurenz Albe
Date:
Subject: Re: 13.2.1. Read Committed Isolation Level