Re: DOCS - pg_replication_slot . Fix the 'inactive_since' description - Mailing list pgsql-hackers

From David G. Johnston
Subject Re: DOCS - pg_replication_slot . Fix the 'inactive_since' description
Date
Msg-id CAKFQuwb-mVbq8iFQsibFnu5GCLsb0ZGhfHxD2U4ARJ6CU1RLbQ@mail.gmail.com
Whole thread Raw
In response to Re: DOCS - pg_replication_slot . Fix the 'inactive_since' description  (Peter Smith <smithpb2250@gmail.com>)
Responses Re: DOCS - pg_replication_slot . Fix the 'inactive_since' description
List pgsql-hackers


On Sun, Sep 8, 2024, 18:55 Peter Smith <smithpb2250@gmail.com> wrote:
Saying "The time..." is fine, but the suggestions given seem backwards to me:
- The time this slot was inactivated
- The time when the slot became inactive.
- The time when the slot was deactivated.

e.g. It is not like light switch. So, there is no moment when the
active slot "became inactive" or "was deactivated".

While this is plausible the existing wording and the name of the field definitely fail to convey this.


Rather, the 'inactive_since' timestamp field is simply:
- The time the slot was last active.
- The last time the slot was active.

I see your point but that wording is also quite confusing when an active slot returns null for this field.

At this point I'm confused enough to need whatever wording is taken to be supported by someone explaining the code that interacts with this field.

I suppose I'm expecting something like: The time the last activity finished, or null if an activity is in-progress.

David J.



pgsql-hackers by date:

Previous
From: Peter Smith
Date:
Subject: Re: DOCS - pg_replication_slot . Fix the 'inactive_since' description
Next
From: Peter Smith
Date:
Subject: Re: DOCS - pg_replication_slot . Fix the 'inactive_since' description