Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Add section headings to index types doc - Mailing list pgsql-hackers

From David G. Johnston
Subject Re: [PATCH] Add section headings to index types doc
Date
Msg-id CAKFQuwYEx+4qwrLJ0ne6vaJef1eurrvL2rv7TDcgcpfLOQA02Q@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Add section headings to index types doc  (ilmari@ilmari.org (Dagfinn Ilmari Mannsåker))
Responses Re: [PATCH] Add section headings to index types doc  (Jürgen Purtz <juergen@purtz.de>)
List pgsql-hackers
Tree view
On Wed, Sep 30, 2020 at 4:25 AM Dagfinn Ilmari Mannsåker <ilmari@ilmari.org> wrote:
Michael Paquier <michael@paquier.xyz> writes:

> On Mon, Aug 10, 2020 at 12:52:17PM +0000, Jürgen Purtz wrote:
>> The new status of this patch is: Waiting on Author
>
> This has not been answered yet, so I have marked the patch as returned
> with feedback.

Updated patch attached, wich reformats the operator lists as requested
by Jürgen,

A couple of things:

One, I would place the equality operator for hash inside a standalone synopsis just like all of the others.
Two, why is hash special in having its create index command provided here? (I notice this isn't the fault of this patch but it stands out when reviewing it)

I would suggest rewording hash to look more like the others and add a link to the "CREATE INDEX" command from the chapter preamble.

and skips the reindentation as suggested by Tom.

Agreed
David J.

pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: Use of "long" in incremental sort code
Next
From: Thomas Munro
Date:
Subject: Re: language cleanups in code and docs