Re: pg_plan_advice - Mailing list pgsql-hackers

From David G. Johnston
Subject Re: pg_plan_advice
Date
Msg-id CAKFQuwY4i6xXCRHd=ccrFz0sQOfiWRxhobiBrzyK0rzu1-Y33Q@mail.gmail.com
Whole thread
In response to Re: pg_plan_advice  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: pg_plan_advice
List pgsql-hackers
On Wed, Mar 4, 2026 at 9:20 AM Robert Haas <robertmhaas@gmail.com> wrote:
On Wed, Mar 4, 2026 at 10:45 AM David G. Johnston
<david.g.johnston@gmail.com> wrote:
> I do need to work in a way to better annotate/comment on the why of these.  Any suggestions for a better flow or feedback format?  Inline comments wrapped in sgml comments?  Or just copy the diff into the email body and inline comment there - leaving the original diff attachment as-is?

My suggestion is to break these fixes up into three categories: clear
errors, stylistic suggestions, substantive concerns.


Thank you for putting in the time to respond.  That was quite helpful.  I've tweaked my tooling to help me remember to do this going forward.

David J.

pgsql-hackers by date:

Previous
From: Pavel Borisov
Date:
Subject: Re: Odd code around ginScanToDelete
Next
From: Jakub Wartak
Date:
Subject: Re: pg_stat_io_histogram