Re: Statistics Import and Export - Mailing list pgsql-hackers

From Greg Sabino Mullane
Subject Re: Statistics Import and Export
Date
Msg-id CAKAnmmL35eCAX-XoqwFzauaoJekyM5aNQpTaWDU2GvjeChkyog@mail.gmail.com
Whole thread Raw
In response to Re: Statistics Import and Export  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On Tue, Apr 1, 2025 at 10:24 PM Robert Haas <robertmhaas@gmail.com> wrote:
On Tue, Apr 1, 2025 at 4:24 PM Jeff Davis <pgsql@j-davis.com> wrote:
> On Tue, 2025-04-01 at 09:37 -0400, Robert Haas wrote:
> > I don't think I was aware of the open item; I was just catching up on
> > email.
>
> I lean towards making it opt-in for pg_dump and opt-out for pg_upgrade.

Big +1.

I may have missed something (we seem to have a lot of threads for this subject), but we are in beta and both pg_dump and pg_upgrade seem to be opt-out? I still object strongly to this;  pg_dump is meant to be a canonical representation of the schema and data. Adding metadata that can change from dump to dump seems wrong, and should be opt-in. I've not been convinced otherwise why stats should be output by default.

To be clear, I 100% want it to be the default for pg_upgrade.

Maybe we are just leaving it enabled to see if anyone complains in beta, but I don't want us to forget about it. :)

Cheers,
Greg

--
Enterprise Postgres Software Products & Tech Support

pgsql-hackers by date:

Previous
From: Álvaro Herrera
Date:
Subject: Re: Restrict publishing of partitioned table with a foreign table as partition
Next
From: "Miguel Ferreira"
Date:
Subject: Request for Implementation of Custom Error Messages for CHECK Constraints