Re: tid_blockno() and tid_offset() accessor functions - Mailing list pgsql-hackers

From Greg Sabino Mullane
Subject Re: tid_blockno() and tid_offset() accessor functions
Date
Msg-id CAKAnmm+gW9J4hr38g0uSUsswAVq+=bUYSSXp9tZrMegLyWieOg@mail.gmail.com
Whole thread
In response to Re: tid_blockno() and tid_offset() accessor functions  (Tomas Vondra <tomas@vondra.me>)
Responses Re: tid_blockno() and tid_offset() accessor functions
List pgsql-hackers
On Sun, Mar 8, 2026 at 3:31 PM Tomas Vondra <tomas@vondra.me> wrote: 
No opinion. For displaying the bogus TID value (like "(-1,0)") it's probably OK to show values that are a bit weird. If anything, we should
be more careful on input, it's too late for tid_block() to decide what to do with an "impossible" TID value.

This one doesn't sit right with me. I think it's not too late. No reason why tid_block cannot be stricter here than tid itself and complain. Other than that, the patch looks good to me.


Cheers,
Greg

pgsql-hackers by date:

Previous
From: Manni Wood
Date:
Subject: Re: Speed up COPY FROM text/CSV parsing using SIMD
Next
From: Nazir Bilal Yavuz
Date:
Subject: Re: Speed up COPY FROM text/CSV parsing using SIMD