Re: [PATCH] Add last_executed timestamp to pg_stat_statements - Mailing list pgsql-hackers

From Pavlo Golub
Subject Re: [PATCH] Add last_executed timestamp to pg_stat_statements
Date
Msg-id CAK7ymc+Kr7i6p_6Hw_2hEg3xVRH8FYnnrEp0PHg+jeMvqH7mLg@mail.gmail.com
Whole thread
In response to Re: [PATCH] Add last_executed timestamp to pg_stat_statements  (Sami Imseih <samimseih@gmail.com>)
Responses Re: [PATCH] Add last_executed timestamp to pg_stat_statements
List pgsql-hackers
Hi!

> I am not sure if this benchmark is enough to build confidence in this approach.
> Workloads with nested queries and tack. 'all' are now paying an even heavier
> cost.

I would love to see and test sql that will reveal the bigger overhead.
Do you have something specific on your mind? I'd love to share
results, we can use them later considering further updates to pgss.

>
> Also, quickly looking at v4, you probably want to call GetCurrentTimestamp()
> when kind == PGSS_EXEC only.


Fair enough! Thanks for noticing!



pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: [PATCH] Provide support for trailing commas
Next
From: Kirill Reshke
Date:
Subject: Re: Don't keep closed WAL segment in page cache after replay