Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin4][patch] Keyboard accessibility for sub-node control - Mailing list pgadmin-hackers

From Ganesh Jaybhay
Subject Re: [pgAdmin4][patch] Keyboard accessibility for sub-node control
Date
Msg-id CAK6syAqgLAVLsWCoevtnWX+V_cgKOQra=oohXwnrzYj7fSp9ug@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin4][patch] Keyboard accessibility for sub-node control  (Dave Page <dpage@pgadmin.org>)
Responses Re: [pgAdmin4][patch] Keyboard accessibility for sub-node control  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers
Tree view
Hi Dave,

Ticket number 3919 refers to keyboard accessibility issues for sub-node control and back grid but this patch covers only sub-node control. Should I create new one?
I have added the screenshot having newly added shortcut and updated keyboard shortcut rst file. Also moved the code changes from backgrid.js to backgrid.pgadmin.js.

Please find the attached updated patch.

Regards,
Ganesh Jaybhay

On Tue, Jul 9, 2019 at 9:28 PM Dave Page <dpage@pgadmin.org> wrote:
Hi,

What's the ticket number for this? That's a fair amount of code for a one-line description. There are also no doc changes describing how to navigate the sub-node control that I can see.

Also; instead of changing the repo used for backgrid, can we not un-vendorise it?

On Mon, Jul 8, 2019 at 4:49 PM Ganesh Jaybhay <ganesh.jaybhay@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch for keyboard accessibility of sub-node control. It also covers sub-node dialog forward/backward tab navigation with shortcuts.

Kindly review.

Regards,
Ganesh Jaybhay


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment

pgadmin-hackers by date:

Previous
From: Khushboo Vashi
Date:
Subject: Re: [GSoC] Finalized First Patch
Next
From: Nagesh Dhope
Date:
Subject: Re: RE-SQL test patch for extension node