On Sat, Apr 4, 2026 at 6:25 AM John Naylor <johncnaylorls@gmail.com> wrote:
>
> On Mon, Mar 30, 2026 at 7:01 PM John Naylor <johncnaylorls@gmail.com> wrote:
> > I'll repeat building pg_filedump with this and if that goes well I
> > plan to push this week unless there are objections.
>
> Something change in my environment, or something, because I can't
> build pg_filedump anymore, although it hasn't had any recent new
> commits:
>
> pg_config
> /bin/sh: line 1: mkdir: command not found
>
> Looks like something messed with PATH, but I don't think it was me. In
> any case, very little has changed in the patch since I last built
> pg_filedump successfully, so I won't worry yet.
>
> I pushed with a couple cosmetic adjustments:
>
> - Removed no-longer-needed #includes from configure checks
> - Added a comment that we deliberately don't guard on __has_attribute
> - switch things around to use #ifdef instead of #ifndef for clarity
>
> Thanks Andrew, for picking this up again!
Thank you for taking care of the final adjustments and pushing the
patch to master.
Thank you again for your guidance and for steering this through to the
finish line.
It was a pleasure collaborating with you on this optimization.
- Andrew
>
> --
> John Naylor
> Amazon Web Services
