mb_regress.sh gripes - Mailing list pgsql-hackers

From Josh Kupershmidt
Subject mb_regress.sh gripes
Date
Msg-id CAK3UJRGVdG=qWS0UcHHA7+C8nRSF=93MA1Kn7awx7K73UUA5=A@mail.gmail.com
Whole thread Raw
Responses Re: mb_regress.sh gripes
List pgsql-hackers
Hi all,

A few gripes about mb_regress.sh:
 1. No exit code is specified, so even if there are differences
between results/ and expected/ the script will still return 0.

 2. The 'dropdb' command is used to wipe out the "utf8" database
before the run. This generates an error message like:
  dropdb: database removal failed: ERROR:  database "utf8" does not exist

the first time you run the script. IMO it would be less startling to
just print a NOTICE here.

 3. No error checking for whether createdb succeeds.

The attached patch fixes these problems.

Josh

Attachment

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: the big picture for index-only scans
Next
From: Tom Lane
Date:
Subject: "make -j4 world" falls over