Re: Transaction commits VS Transaction commits (with parallel) VSquery mean time - Mailing list pgsql-hackers

From Haribabu Kommi
Subject Re: Transaction commits VS Transaction commits (with parallel) VSquery mean time
Date
Msg-id CAJrrPGfZj0OL-Hwym_snjoPR77+gH_cFKLCL2KRZSTfPfiRewQ@mail.gmail.com
Whole thread Raw
In response to Re: Transaction commits VS Transaction commits (with parallel) VSquery mean time  (Amit Kapila <amit.kapila16@gmail.com>)
Responses RE: Transaction commits VS Transaction commits (with parallel) VSquery mean time
List pgsql-hackers

On Thu, Apr 4, 2019 at 3:29 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
On Wed, Apr 3, 2019 at 10:45 AM Haribabu Kommi <kommi.haribabu@gmail.com> wrote:
>
> Thanks for the review.
>
> While changing the approach to use the is_parallel_worker_flag, I thought
> that the rest of the stats are also not required to be updated and also those
> are any way write operations and those values are zero anyway for parallel
> workers.
>
> Instead of expanding the patch scope, I just changed to avoid the commit
> or rollback stats as discussed, and later we can target the handling of all the
> internal transactions and their corresponding stats.
>

The patch looks good to me.  I have changed the commit message and ran
the pgindent in the attached patch.  Can you once see if that looks
fine to you?  Also, we should backpatch this till 9.6.  So, can you
once verify if the change is fine in all bank branches?   Also, test
with a force_parallel_mode option.  I have already tested it with
force_parallel_mode = 'regress' in HEAD, please test it in back
branches as well.


Thanks for the updated patch.
I tested in back branches even with force_parallelmode and it is working
as expected. But the patches apply is failing in back branches, so attached
the patches for their branches. For v11 it applies with hunks.

Regards,
Haribabu Kommi
Fujitsu Australia
Attachment

pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: Emacs vs pg_indent's weird indentation for function declarations
Next
From: "Tsunakawa, Takayuki"
Date:
Subject: RE: Timeout parameters